PostGIS 2.5 error on upgrade view test

[robe]

I think this might be recent because of addition of data upgrade tests

This is on debbie

GEOS config:          /var/lib/jenkins/workspace/geos/rel-3.8w64/bin/geos-config
10:42:11   GEOS version:         3.8.4dev
10:42:11   GDAL config:          /var/lib/jenkins/workspace/gdal/rel-3.4w64/bin/gdal-config
10:42:11   GDAL version:         3.4.3
10:42:11   SFCGAL config:        /usr/bin/sfcgal-config
10:42:11   SFCGAL version:       1.3.8
10:42:11   PostgreSQL config:    /var/lib/jenkins/workspace/pg/rel/pg12w64/bin/pg_config
10:42:11   PostgreSQL version:   PostgreSQL 12.13
10:42:11   PROJ4 version:        72
10:46:40 psql:/var/lib/jenkins/workspace/postgis/branches/2.5/regress/../regress/00-regress-install/share/contrib/postgis/postgis_upgrade.sql:80: NOTICE:  function st_curvetoline(geometry) does not exist, skipping
10:46:40        postgis_major_version_check        
10:46:40 ------------------------------------------
10:46:40  Scripts versions checked for upgrade: ok
10:46:40 (1 row)
10:46:40 
10:46:40 psql:/var/lib/jenkins/workspace/postgis/branches/2.5/regress/../regress/00-regress-install/share/contrib/postgis/postgis_upgrade.sql:3243: ERROR:  cannot drop function st_union(geometry) because other objects depend on it
10:46:40 DETAIL:  view upgrade_view_test depends on function st_union(geometry)
10:46:40 HINT:  Use DROP ... CASCADE to drop the dependent objects too.
10:46:40 CONTEXT:  SQL statement "DROP AGGREGATE IF EXISTS ST_Union (geometry)"
10:46:40 PL/pgSQL function inline_code_block line 7 at EXECUTE
10:46:40 ----------------------------------------------------------------------------

[strk]

It looks like the CREATE OR REPLACE AGGREGATE support did not get into 2.5 branch (3.0 has it as correctly mentioned in NEWS file - ref #4352).

[Sandro Santilli <strk@…>]

In 47f59d9/git:

Do not create an ST_Union based view on upgrade (won't work)

The code to support PG12 CREATE OR REPLACE AGGREGATE entered
the code base in 3.0 so 2.5 does not support such upgrades.

Closes #5287