Opened 16 months ago
Closed 16 months ago
#5435 closed task (fixed)
localize cheatsheets
Reported by: | robe | Owned by: | robe |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS 3.4.0 |
Component: | documentation | Version: | master |
Keywords: | Cc: |
Description
Pushing this for 3.5.0 no rush on it.
The cheatsheets are generated using xls style sheets.
https://postgis.net/docs//manual-3.4/postgis_cheatsheet.html https://postgis.net/docs//manual-3.4/topology_cheatsheet.html https://postgis.net/docs//manual-3.4/raster_cheatsheet.html https://postgis.net/docs//manual-3.4/sfcgal_cheatsheet.html https://postgis.net/docs//manual-3.4/tiger_geocoder_cheatsheet.html
Since all of it except the top footnote detail part (which can be moved into maybe the xls-conf.xml) or refactored to use existing text.
It should be doable.
Change History (19)
comment:1 by , 16 months ago
comment:2 by , 16 months ago
Type: | defect → task |
---|
comment:5 by , 16 months ago
Should the links to official documentation also be localized, at this point ? Right now we find links to https://postgis.net/docs/manual-3.4/PostGIS_Full_Version.html but in postgis_cheatsheet-fr.html it should probably go to https://postgis.net/docs/manual-3.4/fr/PostGIS_Full_Version.html
comment:6 by , 16 months ago
Milestone: | PostGIS 3.5.0 → PostGIS 3.4.0 |
---|
@strk it seems you are done with this task aside from the title at the top.
New in this release 1 Enhanced in this release 2 Requires GEOS 3.9 or higherg3.9 aggregate agg 2.5/3D support3d SQL-MMmm Supports geography G
That we can fix I guess by moving stuff to the xsl-config I think.
So I'm switching this back to 3.4, since seems we'll be done with it before 3.4 release. I'm tempted to just mark it done as it is.
comment:7 by , 16 months ago
I suspect there's more to do, like we're using the "Enhanced" text matching to find out enhanced, rather than the attributes. This should result in less item shown for non-english.
comment:13 by , 16 months ago
As of [77dc645cfc9b252f768fdf14499a421b92b20f0f/git] the header is translatable. The problem I reported in comment:7 is confirmed:
$ grep -c '<sup>1</sup>' html/postgis_cheatsheet-{en,fr}.html html/postgis_cheatsheet-en.html:15 html/postgis_cheatsheet-fr.html:2
Once that is fixed we can close this ticket
comment:15 by , 16 months ago
With [2c159bc11da0a5e62c4f8a68f07dbf3815e39dbc/git] the extraction of those tags is also fixed. I guess we could add a testing rule to verify the count is the same for all tags in all translations, compared to the english version
comment:16 by , 16 months ago
I've added a check-cheatsheets-localized makefile target which currently finds some problem with the G tag (geography support) being inconsistent between languages. It's currently NOT run automatically by any bot, might be eventually
comment:17 by , 16 months ago
Next issue we have is formalization of the requires GEOS > 3.9
snippet, which is currently used by cheatsheet xsl and broken when translated.
Formalization would also be useful to really specify what it means. Right now it's sometimes associated with "availability" and sometimes with "enhanced" tag:
reference_overlay.xml: <para role="enhanced" conformance="3.1.0">Enhanced: 3.1.0 accept a gridSize parameter - requires GEOS >= 3.9.0</para> reference_overlay.xml: <para role="enhanced" conformance="3.1.0">Enhanced: 3.1.0 accept a gridSize parameter - requires GEOS >= 3.9.0</para> reference_overlay.xml: <para role="enhanced" conformance="3.1.0">Enhanced: 3.1.0 accept a gridSize parameter, requires GEOS >= 3.9.0 to use this new feature.</para> reference_overlay.xml: <para role="enhanced" conformance="3.1.0">Enhanced: 3.1.0 accept a gridSize parameter - requires GEOS >= 3.9.0</para> reference_overlay.xml: <para role="enhanced" conformance="3.1.0">Enhanced: 3.1.0 accept a gridSize parameter - requires GEOS >= 3.9.0</para> reference_overlay.xml: <para role="enhanced" conformance="3.1.0">Enhanced: 3.1.0 accept a gridSize parameter - requires GEOS >= 3.9.0</para> reference_processing.xml: <para role="availability" conformance="3.1.0">Availability: 3.1.0 - requires GEOS >= 3.9.0.</para> reference_processing.xml: <para role="availability" conformance="3.4.0">Availability: 3.4.0 - requires GEOS >= 3.9.0.</para> reference_processing.xml: <para role="availability" conformance="3.1.0">Availability: 3.1.0 - requires GEOS >= 3.9.0. </para>
I guess it means it requires that version of GEOS _only_ to use that specific new feature ?
How about completely dropping this indication from the cheatsheets ?
comment:18 by , 16 months ago
For the record, current GEOS stable release is 3.12: http://libgeos.org/usage/download/
comment:19 by , 16 months ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
With 351ebe16f001a51a87fdc41fac459eebe5c240e0 we have formalized geos_requirement role attribute, which makes the check-cheatsheets-localized
makefile target turn green !
I'm closing this ticket as completed. Any further bug is worth its own ticket.
In f5fd56c/git: