3.4.0 beta1 does not honor --datadir

[devrimgunduz]

Hi,

I'm passing --datadir=%{pginstdir}/share/ to configure script to determine the location for .desktop and .png files (desktop icons). However it still wants to install things under /usr/share directory.

This did not happen in earlier series and I did not even pass --datadir to configure script then. All I used was specifying pg_config binary, and it took care of the rest:

/usr/pgsql-15/share/applications/shp2pgsql-gui.desktop
/usr/pgsql-15/share/icons/hicolor/16x16/apps/shp2pgsql-gui.png
/usr/pgsql-15/share/icons/hicolor/22x22/apps/shp2pgsql-gui.png
/usr/pgsql-15/share/icons/hicolor/24x24/apps/shp2pgsql-gui.png
/usr/pgsql-15/share/icons/hicolor/32x32/apps/shp2pgsql-gui.png
/usr/pgsql-15/share/icons/hicolor/36x36/apps/shp2pgsql-gui.png
/usr/pgsql-15/share/icons/hicolor/40x40/apps/shp2pgsql-gui.png
/usr/pgsql-15/share/icons/hicolor/42x42/apps/shp2pgsql-gui.png
/usr/pgsql-15/share/icons/hicolor/48x48/apps/shp2pgsql-gui.png
/usr/pgsql-15/share/icons/hicolor/64x64/apps/shp2pgsql-gui.png
/usr/pgsql-15/share/icons/hicolor/8x8/apps/shp2pgsql-gui.png

Can you please take a look?

Thanks!

Devrim

[strk]

Can you show what exactly is attempted to be installed in /usr/share ? From which directory ? The loader/ directory, which installs the .desktop and icon files, seem to respect the given --datadir for me:

[strk@c19:/usr/local/src/postgis/postgis/loader(main)] make install
mkdir -p /tmp/pgis-share/applications
/usr/bin/install -c -m 644 shp2pgsql-gui.desktop /tmp/pgis-share/applications/shp2pgsql-gui.desktop
for size in 8x8 16x16 22x22 24x24 32x32 36x36 40x40 42x42 48x48 64x64; do \
        mkdir -p /tmp/pgis-share/icons/hicolor/${size}/apps; \
        /usr/bin/install -c -m 644 ./icons/hicolor/${size}/apps/shp2pgsql-gui.png /tmp/pgis-share/icons/hicolor/${size}/apps/shp2pgsql-gui.png; \
done
/bin/bash ../libtool --mode=install /usr/bin/install -c shp2pgsql-gui "/tmp/pgis/bin/shp2pgsql-gui"
libtool: install: /usr/bin/install -c shp2pgsql-gui /tmp/pgis/bin/shp2pgsql-gui
/bin/bash ../libtool --mode=install /usr/bin/install -c pgsql2shp "/tmp/pgis/bin/pgsql2shp"
libtool: install: /usr/bin/install -c pgsql2shp /tmp/pgis/bin/pgsql2shp
/bin/bash ../libtool --mode=install /usr/bin/install -c shp2pgsql "/tmp/pgis/bin/shp2pgsql"
libtool: install: /usr/bin/install -c shp2pgsql /tmp/pgis/bin/shp2pgsql
/bin/bash ../libtool --mode=install /usr/bin/install -c postgis "/tmp/pgis/bin/postgis"
libtool: install: /usr/bin/install -c postgis /tmp/pgis/bin/postgis

The above happens when I configure with --prefix=/tmp/pgis --datadir=/tmp/pgis-share

I confirm we do not default to PG directories now, except for the extension files

[robe]

@devrimgunduz,

Checking if this is still an issue for you.