#5460 closed defect (fixed)
Upstream changes for geography ST_LineLocatePoint to use spheroid, and interpolation fix
Reported by: | robe | Owned by: | pramsey |
---|---|---|---|
Priority: | blocker | Milestone: | PostGIS 3.4.0 |
Component: | postgis | Version: | master |
Keywords: | Cc: |
Description
MobilityDb recently committed these, but have also removed these functions from their project to prevent conflict with PostGIS upgrades. So these will now only reside in PostGIS.
Use spheroid in geography function
https://github.com/MobilityDB/MobilityDB/pull/359
Correctly interpolate between geographic points https://github.com/MobilityDB/MobilityDB/pull/349
Change History (7)
comment:1 by , 16 months ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 by , 16 months ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Guess there is another one - https://github.com/MobilityDB/MobilityDB/pull/353
comment:3 by , 16 months ago
Hmm these all seem to be in place as far as I can tell. Only thing missing are tests. I'll add those
comment:5 by , 16 months ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I realized after I committed the geography_interpolate tests that tests were already in place for these new functions in the geography.sql. I was about to remove the tests I added, when berrie (32-bit failed with this) and gitlab 32-bit failed on this.
06:20:37 regress/core/geography_interpolate .. failed (diff expected obtained: /tmp/pgis_reg/test_115_diff) 06:20:38 ----------------------------------------------------------------------------- 06:20:38 --- ./regress/core/geography_interpolate_expected 2023-07-29 04:11:12.380004361 -0600 06:20:38 +++ /tmp/pgis_reg/test_115_out 2023-07-29 04:20:38.108382789 -0600 06:20:38 @@ -27,6 +27,6 @@ 06:20:38 4180892.366508 06:20:38 297 06:20:38 1 06:20:38 -5520157.913043 06:20:38 +inf 06:20:38 4790369.580943 06:20:38 3215502.296386 06:20:38 -----------------------------------------------------------------------------
gitlab 64-bit is also failing, but that looks to be a rounding difference
--- /builds/postgis/postgis/regress/core/geography_interpolate_expected 2023-07-29 10:09:11.814967894 +0000 +++ /tmp/pgis_reg/test_115_out 2023-07-29 10:14:05.882460007 +0000 @@ -27,6 +27,6 @@ 4180892.366508 297 1 -5520157.913043 +5520157.912684 4790369.580943 3215502.296386 -------------------
comment:6 by , 16 months ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
I'll move the 32-bit and rounding issue to a different ticket and will keep the test out for now. The tests that are failing is a more complex one that uses data from mobilitydbs tests. I'll add that test back after beta2 release.
In fab44d03/git: