Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#5476 closed defect (fixed)

winnie's build script is broken

Reported by: robe Owned by: robe
Priority: blocker Milestone: PostGIS 3.4.0
Component: build Version: master
Keywords: Cc:

Description

Might have been my reshuffling.

I get error on my local

make[2]: Entering directory '/projects/postgis/postgis-git/extensions/postgis'
'C:/MING64~1/projects/POSTGR~1/rel/PG15W6~2/share/extension'
make[2]: C:/MING64~1/projects/POSTGR~1/rel/PG15W6~2/share/extension: No such file or directory
make[2]: *** [C:/MING64~1/projects/POSTGR~1/rel/PG15W6~2/lib/pgxs/src/MAKEFI~1/pgxs.mk:278: installdirs] Error 127

and on hers:

make[2]: Entering directory '/projects/postgis/branches/3.4/extensions/postgis'
'E:/jenkins/postgresql/rel/pg16w64gcc81/share/extension'
make[2]: E:/jenkins/postgresql/rel/pg16w64gcc81/share/extension: No such file or directory
make[2]: *** [E:/jenkins/postgresql/rel/pg16w64gcc81/lib/pgxs/src/makefiles/pgxs.mk:281: installdirs] Error 127
make[2]: Leaving directory '/projects/postgis/branches/3.4/extensions/postgis'
make[1]: *** [Makefile:29: install] Error 1
make[1]: Leaving directory '/projects/postgis/branches/3.4/extensions'
make: *** [GNUmakefile:25: install] Error 1

This must have happened between 8/4 and 8/11

unfortunately I had her off for a couple of days so not sure exactly when. I'm guessing when I was reshuffling the scripts.

What is odd is that E:/jenkins/postgresql/rel/pg16w64gcc81/share/extension exists, though maybe under msys, it's expecting the folder to be called /projects/postgresql/rel/pg16w64gcc81/share/extension

Change History (10)

comment:1 by robe, 15 months ago

Looks like regress is broken too.

I might not have noticed since I was using my custom script

comment:2 by robe, 15 months ago

okay it's failing on my custom script too. I thought I tested this just yesterday and it was working. I'll try to trace when it broke.

comment:3 by robe, 15 months ago

okay looking at my build folder, looks like last time all extensions could install was on 8/10.

And it seems it's only the postgis_tiger_geocoder, address_standardizer, postgis_topology that can't install, cause if I explicitly go into each of the extensions folders, I can install the others

comment:4 by robe, 15 months ago

All right this is even more troubling even though the postgis extensions get installed, it's only installing the ANY and ANY--3.4.0..sql. This is bad, we need all the ANYs because people often uninstall the old version before they install the new.

comment:5 by robe, 15 months ago

Owner: changed from strk to robe

comment:6 by robe, 15 months ago

I think the lack of install of others might be just mingw specific - relooking at debbie, I think all are there from last install.

comment:7 by robe, 15 months ago

Okay what broke it is #5469. I thought postgis install was working, but that was because I had hand edited that script. It's broken like the others.

The issue is on windows,

MKDIR_P = @MKDIR_P@

ends up becoming

MKDIR_P =

and that seems to break everything

I'm testing to confirm

comment:8 by Regina Obe <lr@…>, 15 months ago

Resolution: fixed
Status: newclosed

In 03dbb475/git:

MKDIR_P only override if it's not empty

Closes #5469 for PostGIS 3.4.0rc3
Closes #5476 for PostGIS 3.4.0rc3

comment:9 by Regina Obe <lr@…>, 15 months ago

In 0160392/git:

Wrong syntax for ifdef in prior commit

References #5476
References #5469
Closes https://git.osgeo.org/gitea/postgis/postgis/pulls/137

comment:10 by Regina Obe <lr@…>, 15 months ago

In f4348fe/git:

Fix mingw64 install

References #5469
References #5476

for PostGIS 3.5.0dev

Note: See TracTickets for help on using tickets.