Opened 15 months ago
Closed 13 months ago
#5497 closed enhancement (fixed)
Test double upgrades with locking views
Reported by: | strk | Owned by: | pramsey |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS 3.5.0 |
Component: | postgis | Version: | master |
Keywords: | Cc: |
Description
The bug reported in #5494 only affects running an upgrade procedure twice while a view holds back some deprecated function.
This resulted in no bots ever catching it, which is a pity. This ticket is to improve the testsuite to also test this case.
The double upgrade could re-use the existing pre-upgrade hooks to install the locking views, then run an ad-hoc test running an additional upgrade, and call all of this via run_test.pl --upgrade which would be doing the first upgrade.
I've done this locally but would like to automate it somehow.
I think running ALL tests would be overkill so this is really something we only want to do with an ad-hoc test
Change History (7)
comment:1 by , 15 months ago
comment:7 by , 13 months ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
At the moment "locked upgrade" is always tested by make check
, due to regress/runtest.mk including the use_all_functions.sql hook. This means make check-double-upgrade
is already testing locked-double-upgrade and both Dronie and Woodie are running make check-double-upgrade
, so I'll close this ticket as completed.
In 84ed9355/git: