Opened 13 months ago
Closed 13 months ago
#5573 closed task (fixed)
Enable postgis_restore based upgrade tests in CI
Reported by: | strk | Owned by: | robe |
---|---|---|---|
Priority: | medium | Milestone: | Website Management, Bots |
Component: | QA/buildbots | Version: | |
Keywords: | Cc: |
Description
Since commit [ecea1b90e42943d78affaf8ddb96dbacc198f9a9/git] we support testing postgis_restore.pl but it looks like none of our bots are testing those upgrades from 2.5 or they would catch issue #5569
Change History (9)
comment:1 by , 13 months ago
comment:3 by , 13 months ago
It looks like CI testing unpackaged was removed by commits [f43042025de04b44af6e3ee70bd5204177fd5559/git] and [0dae51d2620920f2a21bcb5feaa59b020db83a38/git] referencing issue #5341
Regina: is that something that maybe should be fixed on the debbie side instead ?
comment:5 by , 13 months ago
We're now testing unpackaged upgrades,see: https://woodie.osgeo.org/repos/30/pipeline/1321/7#L15378
Testing dumprestore now could be done either passing the --dumprestore switch in RUNTESTFLAGS from the outside of check_all_upgrades.sh or by making that script explicitly test the dumprestore in addition to the soft upgrade. Given extension-based --dumprestore is probably not that interesting I'm leaning toward the second choice, maybe with a --skip-hard-upgrade to eventually avoid that if it fails (we know it fails)
comment:6 by , 13 months ago
Experimental dumprestore upgrade based test enabled in https://git.osgeo.org/gitea/postgis/postgis/pulls/159 -- let's see if it is able to catch #5569 and #5574
comment:7 by , 13 months ago
Test effectively catches upgrade bugs \o/ https://woodie.osgeo.org/repos/30/pipeline/1324/7
Will rebase to see if recent commit fixed them all or not (I guess not, but at least some)
postgis_upgrade from 3.0 is already failing in master:
This is to show the urgency of the added CI test