Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#5679 closed defect (fixed)

sfcgal.sql:xxx: WARNING: there is no transaction in progress

Reported by: strk Owned by: lbartoletti
Priority: medium Milestone: PostGIS 3.3.6
Component: sfcgal Version: master
Keywords: Cc:

Description

There seem to be some transaction statements in sfcgal.sql which result in warnings shown by the new run_test.pl bailing out on warnings: 

Loading SFCGAL into 'postgis_reg'
psql:/usr/local/src/postgis/postgis/build/pg13/regress/00-regress-install/share/contrib/postgis/sfcgal.sql:193: WARNING:  there is no transaction in progress
psql:/usr/local/src/postgis/postgis/build/pg13/regress/00-regress-install/share/contrib/postgis/sfcgal.sql:201: WARNING:  there is no transaction in progress
psql:/usr/local/src/postgis/postgis/build/pg13/regress/00-regress-install/share/contrib/postgis/sfcgal.sql:209: WARNING:  there is no transaction in progress
psql:/usr/local/src/postgis/postgis/build/pg13/regress/00-regress-install/share/contrib/postgis/sfcgal.sql:217: WARNING:  there is no transaction in progress
psql:/usr/local/src/postgis/postgis/build/pg13/regress/00-regress-install/share/contrib/postgis/sfcgal.sql:225: WARNING:  there is no transaction in progress
psql:/usr/local/src/postgis/postgis/build/pg13/regress/00-regress-install/share/contrib/postgis/sfcgal.sql:233: WARNING:  there is no transaction in progress
psql:/usr/local/src/postgis/postgis/build/pg13/regress/00-regress-install/share/contrib/postgis/sfcgal.sql:241: WARNING:  there is no transaction in progress
psql:/usr/local/src/postgis/postgis/build/pg13/regress/00-regress-install/share/contrib/postgis/sfcgal.sql:249: WARNING:  there is no transaction in progress
psql:/usr/local/src/postgis/postgis/build/pg13/regress/00-regress-install/share/contrib/postgis/sfcgal.sql:257: WARNING:  there is no transaction in progress
psql:/usr/local/src/postgis/postgis/build/pg13/regress/00-regress-install/share/contrib/postgis/sfcgal.sql:265: WARNING:  there is no transaction in progress

Change History (8)

comment:2 by strk, 8 months ago

The problem can be tested by merging ​https://git.osgeo.org/gitea/postgis/postgis/pulls/174 and running: regress/run_test.pl --sfcgal regress/core/regress.sql

It doesn't metter what test is being run

comment:3 by Sandro Santilli <strk@…>, 8 months ago

Resolution: → fixed
Status: new → closed

In 02580d8/git:

sfcgal.sql.in: Fix extra COMMIT; statements

Closes #5679

comment:4 by strk, 8 months ago

Milestone: PostGIS 3.5.0 → PostGIS 3.4.3
Resolution: fixed
Status: closed → reopened

Reopening as stable-3.4 branch is also affected

comment:5 by strk, 8 months ago

Milestone: PostGIS 3.4.3 → PostGIS 3.3.6

Also stable-3.3 is affected. I'm backporting the fix.

comment:6 by Sandro Santilli <strk@…>, 8 months ago

In a22f29c/git:

Remove spurious COMMIT statements from sfcgal sql script

References #5679 in 3.4 branch (3.4.3dev)

comment:7 by Sandro Santilli <strk@…>, 8 months ago

Resolution: → fixed
Status: reopened → closed

In 29037e7/git:

Remove spurious COMMIT statements from sfcgal sql script

Closes #5679 in 3.3 branch (3.3.7dev)

comment:8 by Sandro Santilli <strk@…>, 8 months ago

In 3401974/git:

Have run_test.pl bail out on WARNINGS during script-based db preparation

References #5678
References #5679

Note: See TracTickets for help on using tickets.