TopoGeo_LoadGeometry coredumps database when NULL geometry

[Lars Aksel Opsahl]

On

POSTGIS="3.5.0dev 3.4.0rc1-1087-g2e4d96393" [EXTENSION] PGSQL="140" GEOS="3.12.1-CAPI-1.18.1" PROJ="9.4.0 NETWORK_ENABLED=OFF URL_ENDPOINT=https://cdn.proj.org USER_WRITABLE_DIRECTORY=/Users/lop/Library/Application Support/proj DATABASE_PATH=/opt/homebrew/Cellar/proj/9.4.0/share/proj/proj.db" LIBXML="2.13.0" LIBJSON="0.17" TOPOLOGY

PostgreSQL 14.11 (Homebrew) on aarch64-apple-darwin23.2.0, compiled by Apple clang version 15.0.0 (clang-1500.1.0.2.5), 64-bit

Running this command

SELECT topology.CreateTopology ('t1', 4258 , 0);
 createtopology 
----------------
              3
(1 row)

select topology.TopoGeo_LoadGeometry('t1',null::geometry,0::float8);

I get this response

server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.

And the log I find this

2024-04-15 10:56:13.390 CEST [35641] LOG:  server process (PID 35927) was terminated by signal 11: Segmentation fault: 11

[strk]

Confirmed, I'm on it. The function is new in 3.5 so only master needs be fixed

[Sandro Santilli <strk@…>]

In 1d12c31/git:

Fix crash on NULL geometry input to LoadGeometry

Also short-circuit the EMPTY case
Includes regress test.

Closes #5712