#1719 closed enhancement (fixed)
Add support for Point and GeometryCollection ST_MakeValid inputs
| Reported by: | strk | Owned by: | pramsey |
|---|---|---|---|
| Priority: | medium | Milestone: | PostGIS 2.1.0 |
| Component: | postgis | Version: | master |
| Keywords: | history | Cc: |
Description
There's no reason to break out of a transaction only because POINT is not supported by ST_MakeValid... Just return the input point !
Change History (7)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
| Summary: | Add Point support in ST_MakeValid → Do not throw an exception on unsupported ST_MakeValid input |
|---|
Can't confirm the empty case:
strk=# select ST_AsEWKT(ST_MakeValid('POLYGON EMPTY'));
st_asewkt
---------------
POLYGON EMPTY
(1 row)
But GEOMETRYCOLLECTION is a problem !
trk=# select ST_AsEWKT(ST_MakeValid('GEOMETRYCOLLECTION EMPTY'));
ERROR: ST_MakeValid: unsupported geometry type GeometryCollection
comment:3 by , 13 years ago
| Summary: | Do not throw an exception on unsupported ST_MakeValid input → Add support for Point and GeometryCollection ST_MakeValid inputs |
|---|
For the GEOMETRYCOLLECTION type we actually want to _add_ the support, not just return the input
comment:5 by , 13 years ago
r9554 adds acceptance of points. Note that points are just returned the way they are.
comment:6 by , 12 years ago
| Milestone: | PostGIS 2.0.1 → PostGIS 2.1.0 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
| Type: | defect → enhancement |
Yep, it's a feature. Implemented in trunk with r9892.
comment:7 by , 12 years ago
| Keywords: | history added |
|---|
Note:
See TracTickets
for help on using tickets.
To double check but I think ST_MakeValid also fails when the geometry is empty. There's no reason to break out of a transaction only because EMPTY is not supported by ST_MakeValid...