proj_api.h does not exist

[robe]

I've suddenly starting getting this error on winnie.

make[2]: Entering directory '/projects/postgis/branches/3.0/loader/cunit'
x86_64-w64-mingw32-gcc -Wall -Wmissing-prototypes -std=gnu99 -Wall -fno-omit-frame-pointer -fno-math-errno -fno-signed-zeros  -I/projects/rel-libiconv-1.13.1w64gcc48/include -I/projects/postgresql/rel/pg10w64gcc48/include -I/projects/rel-libiconv-1.13.1w64gcc48/include -I.. -mms-bitfields -IE:/jenkins/gtkw64gcc48/include/gtk-2.0 -IE:/jenkins/gtkw64gcc48/lib/gtk-2.0/include -IE:/jenkins/gtkw64gcc48/include/atk-1.0 -IE:/jenkins/gtkw64gcc48/include/cairo -IE:/jenkins/gtkw64gcc48/include/gdk-pixbuf-2.0 -IE:/jenkins/gtkw64gcc48/include/pango-1.0 -IE:/jenkins/gtkw64gcc48/include/glib-2.0 -IE:/jenkins/gtkw64gcc48/lib/glib-2.0/include -IE:/jenkins/gtkw64gcc48/include/pixman-1 -IE:/jenkins/gtkw64gcc48/include -IE:/jenkins/gtkw64gcc48/include/freetype2 -IE:/jenkins/gtkw64gcc48/include/libpng14    -IE:/jenkins/postgresql/rel/pg10w64gcc48/include -c -o cu_pgsql2shp.o cu_pgsql2shp.c
x86_64-w64-mingw32-gcc -Wall -Wmissing-prototypes -std=gnu99 -Wall -fno-omit-frame-pointer -fno-math-errno -fno-signed-zeros  -I/projects/rel-libiconv-1.13.1w64gcc48/include -I/projects/postgresql/rel/pg10w64gcc48/include -I/projects/rel-libiconv-1.13.1w64gcc48/include -I.. -mms-bitfields -IE:/jenkins/gtkw64gcc48/include/gtk-2.0 -IE:/jenkins/gtkw64gcc48/lib/gtk-2.0/include -IE:/jenkins/gtkw64gcc48/include/atk-1.0 -IE:/jenkins/gtkw64gcc48/include/cairo -IE:/jenkins/gtkw64gcc48/include/gdk-pixbuf-2.0 -IE:/jenkins/gtkw64gcc48/include/pango-1.0 -IE:/jenkins/gtkw64gcc48/include/glib-2.0 -IE:/jenkins/gtkw64gcc48/lib/glib-2.0/include -IE:/jenkins/gtkw64gcc48/include/pixman-1 -IE:/jenkins/gtkw64gcc48/include -IE:/jenkins/gtkw64gcc48/include/freetype2 -IE:/jenkins/gtkw64gcc48/include/libpng14    -IE:/jenkins/postgresql/rel/pg10w64gcc48/include -c -o cu_shp2pgsql.o cu_shp2pgsql.c
In file included from ../../liblwgeom/liblwgeom_internal.h:48:0,
                 from ../../liblwgeom/stringbuffer.h:30,
                 from ../shp2pgsql-core.h:30,
                 from cu_shp2pgsql.c:14:
../../liblwgeom/liblwgeom.h:35:22: fatal error: proj_api.h: No such file or directory
 #include "proj_api.h"
                      ^
compilation terminated.
Makefile:87: recipe for target 'cu_shp2pgsql.o' failed
make[2]: *** [cu_shp2pgsql.o] Error 1
make[2]: Leaving directory '/projects/postgis/branches/3.0/loader/cunit'
Makefile:156: recipe for target 'check' failed
make[1]: *** [check] Error 2
make[1]: Leaving directory '/projects/postgis/branches/3.0/loader'
GNUmakefile:16: recipe for target 'check' failed
make: *** [check] Error 1

What's weird is everything runs fine until it get to regress of loader so I definitely have proj but the loader is not seeing it.

PostgreSQL 10.4, compiled by Visual C++ build 1800, 64-bit
  Postgis 3.0.0dev - r16871 - 2018-10-02 13:50:23
  scripts 3.0.0dev r16871
  GEOS: 3.7.0-CAPI-1.11.0 3.7.0
  PROJ: Rel. 4.9.3, 15 August 2016

Running tests

 regress/legacy_validate .. ok 
 regress/legacy_predicate .. ok 
 regress/legacy_invalid .. ok 
 regress/sqlmm .. ok 
 regress/legacy_query .. ok 
 regress/addnode .. ok 
 regress/addedge .. ok 
 regress/addface .. ok 
 regress/addface2.5d .. ok 
 regress/addtopogeometrycolumn .. ok 
 regress/polygonize .. ok 
 regress/st_addisoedge .. ok 
 regress/st_addisonode .. ok 
 regress/st_addedgemodface .. ok 
 regress/st_addedgenewfaces .. ok 
 regress/st_changeedgegeom .. ok 
 regress/st_createtopogeo .. ok 
 regress/st_getfacegeometry .. ok 
 regress/st_getfaceedges .. ok 
 regress/st_modedgeheal .. ok 
 regress/st_modedgesplit .. ok 
 regress/st_newedgeheal .. ok 
 regress/st_newedgessplit .. ok 
 regress/st_remedgenewface .. ok 
 regress/st_remedgemodface .. ok 
 regress/st_simplify .. ok 
 regress/topoelement .. ok 
 regress/topoelementarray_agg .. ok 
 regress/topogeo_addlinestring .. ok 
 regress/topogeo_addpoint .. ok 
 regress/topogeo_addpolygon .. ok 
 regress/topogeom_edit .. ok 
 regress/topogeometry_type .. ok 
 regress/topojson .. ok 
 regress/topologysummary .. ok 
 regress/topo2.5d .. ok 
 regress/totopogeom .. ok 
 regress/droptopology .. ok 
 regress/droptopogeometrycolumn .. ok 
 regress/copytopology .. ok 
 regress/createtopogeom .. ok 
 regress/createtopology .. ok 
 regress/gml .. ok 
 regress/getnodebypoint .. ok 
 regress/getedgebypoint .. ok 
 regress/getfacebypoint .. ok 
 regress/getringedges .. ok 
 regress/gettopogeomelements .. ok 
 regress/layertrigger .. ok 
 regress/validatetopology .. ok 
 uninstall .  /projects/postgis/branches/3.0/regress/00-regress-install/share/contrib/postgis/uninstall_topology.sql
  /projects/postgis/branches/3.0/regress/00-regress-install/share/contrib/postgis/uninstall_postgis.sql
. ok (4663)

Run tests: 51
Failed: 0
make[2]: Leaving directory '/projects/postgis/branches/3.0/topology/test'
make[1]: Leaving directory '/projects/postgis/branches/3.0/topology'
---- Making check in loader
make[1]: Entering directory '/projects/postgis/branches/3.0/loader'
make -C cunit check
make[2]: Entering directory '/projects/postgis/branches/3.0/loader/cunit'
x86_64-w64-mingw32-gcc -Wall -Wmissing-prototypes -std=gnu99 -Wall -fno-omit-frame-pointer -fno-math-errno -fno-signed-zeros  -I/projects/rel-libiconv-1.13.1w64gcc48/include -I/projects/postgresql/rel/pg10w64gcc48/include -I/projects/rel-libiconv-1.13.1w64gcc48/include -I.. -mms-bitfields -IE:/jenkins/gtkw64gcc48/include/gtk-2.0 -IE:/jenkins/gtkw64gcc48/lib/gtk-2.0/include -IE:/jenkins/gtkw64gcc48/include/atk-1.0 -IE:/jenkins/gtkw64gcc48/include/cairo -IE:/jenkins/gtkw64gcc48/include/gdk-pixbuf-2.0 -IE:/jenkins/gtkw64gcc48/include/pango-1.0 -IE:/jenkins/gtkw64gcc48/include/glib-2.0 -IE:/jenkins/gtkw64gcc48/lib/glib-2.0/include -IE:/jenkins/gtkw64gcc48/include/pixman-1 -IE:/jenkins/gtkw64gcc48/include -IE:/jenkins/gtkw64gcc48/include/freetype2 -IE:/jenkins/gtkw64gcc48/include/libpng14    -IE:/jenkins/postgresql/rel/pg10w64gcc48/include -c -o cu_pgsql2shp.o cu_pgsql2shp.c
x86_64-w64-mingw32-gcc -Wall -Wmissing-prototypes -std=gnu99 -Wall -fno-omit-frame-pointer -fno-math-errno -fno-signed-zeros  -I/projects/rel-libiconv-1.13.1w64gcc48/include -I/projects/postgresql/rel/pg10w64gcc48/include -I/projects/rel-libiconv-1.13.1w64gcc48/include -I.. -mms-bitfields -IE:/jenkins/gtkw64gcc48/include/gtk-2.0 -IE:/jenkins/gtkw64gcc48/lib/gtk-2.0/include -IE:/jenkins/gtkw64gcc48/include/atk-1.0 -IE:/jenkins/gtkw64gcc48/include/cairo -IE:/jenkins/gtkw64gcc48/include/gdk-pixbuf-2.0 -IE:/jenkins/gtkw64gcc48/include/pango-1.0 -IE:/jenkins/gtkw64gcc48/include/glib-2.0 -IE:/jenkins/gtkw64gcc48/lib/glib-2.0/include -IE:/jenkins/gtkw64gcc48/include/pixman-1 -IE:/jenkins/gtkw64gcc48/include -IE:/jenkins/gtkw64gcc48/include/freetype2 -IE:/jenkins/gtkw64gcc48/include/libpng14    -IE:/jenkins/postgresql/rel/pg10w64gcc48/include -c -o cu_shp2pgsql.o cu_shp2pgsql.c
In file included from ../../liblwgeom/liblwgeom_internal.h:48:0,
                 from ../../liblwgeom/stringbuffer.h:30,
                 from ../shp2pgsql-core.h:30,
                 from cu_shp2pgsql.c:14:
../../liblwgeom/liblwgeom.h:35:22: fatal error: proj_api.h: No such file or directory
 #include "proj_api.h"
                      ^

Looks like recent changes happened to loader at r16863 for #4189 pull request - ​https://github.com/postgis/postgis/pull/310 which I think got committed to all stable branches

Unfortunately I was in middle of making changes myself so winnie has been failing for other reasons.

[Algunenano]

Doesn't loader/cunit/Makefile.in need to include @PROJ_CPPFLAGS@ as part of its CFLAGS?

I'll give it a try.

[Raul Marin]

In 16875:

Loader cunit: Add proj flags

References #4194
Closes ​https://github.com/postgis/postgis/pull/314

[Algunenano]

Trunk seems to be fixed by that patch. Other branches seem to be broken for other reasons, so I'm closing this without backporting the patch for now.