Opened 2 years ago

Closed 17 months ago

#5297 closed defect (fixed)

woodie and dronie not picking up docbook check issues

Reported by: robe Owned by: robe
Priority: critical Milestone: PostGIS 3.4.0
Component: QA/buildbots Version: master
Keywords: Cc:

Description

I don't know if this is an issue with the parallel build. That's the only real difference I see between dronie/woodie setup and the other cis.

The other cis were able to pick up this docbook check error:

https://github.com/postgis/postgis/actions/runs/3610840750/jobs/6084879392

But dronie and woodie showed green lights.

https://woodie.osgeo.org/postgis/postgis/build/16/10

except for failure in pg14 which looks unrelated

Change History (8)

comment:1 by strk, 22 months ago

On line 1801 of the woodie build I read:

configure was unable to find 'xmllint' which is required to test the documentation.

I guess we want make check to fail in that case rather than moving on

comment:2 by robe, 19 months ago

Milestone: PostGIS 3.3.3PostGIS 3.4.0

comment:3 by strk, 18 months ago

Regina: you intentionally removed docs building in dronie with [56d525e779fa814893a2a3cf772c1980a270b0d9/git]

I've added xmllint to the test image with https://git.osgeo.org/gitea/postgis/postgis-docker/commit/1a130b8ea7ae2d00baa35c13f7bf2378f1cec3a5 so once the new image is uploaded we should have better tests ( see also https://git.osgeo.org/gitea/postgis/postgis-docker/issues/11 )

comment:4 by strk, 18 months ago

for the record: install of xmllint should have been done properly with https://git.osgeo.org/gitea/postgis/postgis-docker/commit/9f8b62e94da65750ffda336d5f0b906b75a65919

Last edited 18 months ago by strk (previous) (diff)

comment:5 by strk, 18 months ago

I've started build https://debbie.postgis.net/view/PostGIS/job/PostGIS-docker/33/ which hopefully will result in publishing the updated image

comment:6 by robe, 17 months ago

Resolution: fixed
Status: newclosed

comment:7 by strk, 17 months ago

Resolution: fixed
Status: closedreopened

A Woodie build from 2 days ago is still missing xmllint: https://woodie.osgeo.org/postgis/postgis/build/429/7

I guess we need to add pull:true to the image config, see https://woodpecker-ci.org/docs/usage/pipeline-syntax

comment:8 by Sandro Santilli <strk@…>, 17 months ago

Resolution: fixed
Status: reopenedclosed

In 6d4ef08f/git:

Have woodie always pull docker images

Closes #5297

Note: See TracTickets for help on using tickets.