CopyTopology: ERROR: TopoGeometry 14678 does not exist in the child layer 1

[strk]

When trying to copy a topology I get this error:

CopyTopology: ERROR: TopoGeometry 14678 does not exist in the child layer 1

Context:

PL/pgSQL relationtrigger() riga 59 a RAISE
istruzione SQL "
      INSERT INTO topo_italia_20221207.relation
      SELECT * FROM topo_italia.relation
    "
funzione PL/pgSQL copytopology(character varying,character varying) riga 83 a EXECUTE 

PostGIS version is 3.3.1

[strk]

It would be useful for the message (at the bare minimum) to report the ID of the topogeometry

[strk]

Interesting enough, the topogeometry DOES exist in the relation table for layer_id=1:

=# Select * from topo_italia.relation where topogeo_id = 14678;
 topogeo_id | layer_id | element_id | element_type
------------+----------+------------+--------------
      14678 |        1 |       1769 |            3 

[strk]

I could reproduce the problem locally by running an UPDATE of relation records associated with primitive layers, so that they would be processed LAST in the INSERT query shown as context:

=# update topo_italia.relation set layer_id = 1 where layer_id = 1;
UPDATE 8756
toto=# select copytopology('topo_italia', 'topo_italia20221207');
ERROR:  TopoGeometry 7590 does not exist in the child layer 1
CONTEXT:  PL/pgSQL function relationtrigger() line 59 at RAISE
SQL statement "
      INSERT INTO topo_italia20221207.relation
      SELECT * FROM topo_italia.relation
    "
PL/pgSQL function copytopology(character varying,character varying) line 83 at EXECUTE

Basically the relationtrigger seems to be running for each row instead of for each statement and it does not allow insertint a record of a hierarchical topogeometry BEFORE the underlying topogeometry.

One solution should be to disable the trigger during the copy and re-enable it afterwards.

[strk]

Testcase pushed in ​https://git.osgeo.org/gitea/postgis/postgis/pulls/117 --- fix yet to be implemented

[Sandro Santilli <strk@…>]

In 68f392d/git:

Ensure CopyTopology does not violate layer triggers

Makes sure hierarchical TopoGeometry definitions are always
loaded AFTER the primitives defining them.

References #5298 in master branch (3.4.0dev)

Includes regression test

[Sandro Santilli <strk@…>]

In dbb8913/git:

Ensure CopyTopology does not violate layer triggers

Makes sure hierarchical TopoGeometry definitions are always
loaded AFTER the primitives defining them.

Closes #5298 in 3.3 branch (3.3.3dev)

Includes regression test

[strk]

Although 3.2 and earlier are also affected the patch doesn't apply cleanly and I don't think it's worth spending the time on backporting further anyway, given the many topology improvements in 3.3